Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eclipse_conical issue #11

Open
kevin-tracy opened this issue Jun 10, 2021 · 0 comments
Open

eclipse_conical issue #11

kevin-tracy opened this issue Jun 10, 2021 · 0 comments

Comments

@kevin-tracy
Copy link

There is an issue with eclipse_conical. Here is a simple example where eclipse_cylindrical gives the expected result but eclipse_conical does not:

julia> eclipse_cylindrical(R_EARTH*1.2*[1;0;0],AU*[1;0;0]) # should be fully illuminated (1.0)
1.0

julia> eclipse_conical(R_EARTH*1.2*[1;0;0],AU*[1;0;0])     # should be fully illuminated (1.0)
0.0

This isn't caught by the tests because it looks like the expected illuminations are flipped here: https://github.com/sisl/SatelliteDynamics.jl/blob/master/test/test_orbitdynamics.jl#L107. I'll submit a PR this weekend with the fix for this, but I figured I would add an issue anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant