Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the async commit #716

Open
JohannesLichtenberger opened this issue Apr 19, 2024 · 1 comment
Open

Fix the async commit #716

JohannesLichtenberger opened this issue Apr 19, 2024 · 1 comment

Comments

@JohannesLichtenberger
Copy link
Member

JohannesLichtenberger commented Apr 19, 2024

See the async-commit branch and the JsonNodeTrxAsyncCommitTest integration tests. There's currently one or more race conditions...

Notes:

  • PageReferences can't be copied, they have to be shared between the former revision (going to be written to disk) and the new revision (kept in an in-memory trx intent log), as some keys or none at all may be written to disk at that point (thus, stored, once it's written to disk -- storing the file offset).
  • The List of PageFragments must create a new PageReference for the former revision, as otherwise the PageReference would store the new key/offset once it's written to disk.
@xDido
Copy link

xDido commented Sep 13, 2024

this comment might be a beginner comment excuse me, I'm getting memory issues when trying to run the test, is this the problem? it keeps creating new PageReferences instead of using the same one ?
I'm on 16GB of Ram

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants