Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp CSS #5

Open
sir4ur0n opened this issue Dec 2, 2019 · 5 comments
Open

Revamp CSS #5

sir4ur0n opened this issue Dec 2, 2019 · 5 comments

Comments

@sir4ur0n
Copy link
Owner

sir4ur0n commented Dec 2, 2019

Current CSS is maybe a bit too dull. Find another main color and revamp CSS accordingly

@m-renaud
Copy link

It also isn't super mobile friendly, the below is how it renders on a Pixel 3XL, notice how small the font is and that it only uses half of the screen.

screenshot.

@sir4ur0n
Copy link
Owner Author

@xvw if you are able to help me on this one, I'll gladly accept the help 😄

@xvw
Copy link
Contributor

xvw commented Apr 21, 2020

To be honnest, even we can find a CSS-approach, I think that you should just "split" the type signatures in multiple lines.

@sir4ur0n
Copy link
Owner Author

My bad, I thought you had this display issue on all pages, not just on https://sir4ur0n.github.io/posts/polysemy-first-example.html in which case it would have been a global CSS issue.

@xvw kindly fixed this in #9, let me know if it's better for you.

@m-renaud To be clear: this display issue was only on this page, right? Not on all pages?

@m-renaud
Copy link

@sir4ur0n I just forced refreshed everything and it's much better now (see screenshot below), although slightly larger font size wouldn't hurt since it's still a bit on the small size.

Screenshot_20200421-075201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants