Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Access-Control-Allow-Origin header to harp server (CORS) #512

Closed
Prinzhorn opened this issue Nov 10, 2015 · 3 comments
Closed

Add Access-Control-Allow-Origin header to harp server (CORS) #512

Prinzhorn opened this issue Nov 10, 2015 · 3 comments

Comments

@Prinzhorn
Copy link
Contributor

I couldn't find any existing discussion about this, maybe I'm doing something exotic. Locally I have my node app on localhost:3000 and harp on localhost:9000 for serving static files (which is done via S3/CloudFront in production, with precompiled SASS etc.). The sad thing is that fonts/fontawesome won't work correctly:

Font from origin 'http://localhost:9000' has been blocked from loading by Cross-Origin Resource Sharing policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://localhost:3000' is therefore not allowed access.

Is adding an option to enable CORS for harp server something you would consider doing?

@sintaxi
Copy link
Owner

sintaxi commented Nov 20, 2015

Yep. Im down with this. We'll try to get this into one of the next releases.

@Prinzhorn
Copy link
Contributor Author

Will PR

@Prinzhorn
Copy link
Contributor Author

Closing in favor on #514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants