-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for on-prem GitLab #580
Comments
I need this feature! Has any work towards it been done? Happy to take a crack at it if it's up for grabs. |
I think maybe we added this - @muffato was there more work to do or did we forget to close it? |
Thanks to @phue (#631), there is now support on the However that pattern seems to contravene GitLab's rule that Pages cannot be on a subdomain of GitLab itself, see https://docs.gitlab.com/ee/administration/pages/#prerequisites With @vsoch we started some work in #585 to address both this issue and #581 . The pull-request now has a few conflicts that could probably be solved, but I don't think it's complete. I somehow can't see how it was supposed to handle self-hosted GitLab. At the moment, the part that works the best in #585 is the support for private registries that don't expose the JSON over Pages, and for which shpc falls back to In summary, @georgiastuart , can you first check your Pages setup and if it works with the code on |
Hm I see, looks like there are many ways to deploy gitlab. I did not configure gitlab myself, but I have worked at two institutions where it was configured like this ( e.g |
I'm not ready to PR yet, but I got this working by implementing a "generic" provider that just checks if the Our gitlab pages domain is completely separate from our gitlab domain. |
Partly I'm not ready to PR since I had to jam in some hacky stuff to make it work with a URL that has a port for the container registry in the |
#576 adds support for remote registries hosted at gitlab.com. GitLab can also be deployed on prem, i.e. at a different URL.
For this to work, the code would have to:
shpc docgen
)For pages, I propose to extend shpc/settings.yml to allow a mapping between the server of the git repository and the location of its pages. The default config would be:
and users could add there their own settings.
This would also remove the need for defining classes
GitHub
andGitLab
inshpc/main/registry/remote.py
(and use those inshpc/main/registry/__init__.py
). A registry would be considered as remote as soon as it starts withhttps://
, and to be valid, its server would have to be found in the config file.The text was updated successfully, but these errors were encountered: