You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not sure if this would be a breaking change for some, so I want to discuss before sending in a PR.
I'm having to build a unique grammar for a binary column and realized that the Grammar class doesn't uniquely identify itself like the other drivers in the ecosystem for laravel. For example, MySqlGrammar, PostgresGrammar, etc.
If we make this change, than anyone using the Grammar class to override or add macros would cause breaking changes. I think this is better for the long term and want to put it on the radar.
Thoughts? I'm happy to make a PR if this is the direction you want to go.
It sounds like a nice idea.
The same can be done for several more places
use Illuminate\Database\Schema\Grammars\MySqlGrammar;
class Grammar extends MySqlGrammar
use Illuminate\Database\Schema\MySqlBuilder;
class Builder extends MySqlBuilder
use Illuminate\Database\MySqlConnection;
class Connection extends MySqlConnection
use Illuminate\Database\Connectors\MySqlConnector;
class Connector extends MySqlConnector
use Illuminate\Database\Query\Builder as BaseBuilder;
class Builder extends BaseBuilder
use Illuminate\Database\Query\Grammars\MySqlGrammar;
class Grammar extends MySqlGrammar
All these classes can be prefixed with SingleStore.
I think it is a good direction to go. As it is a breaking change - a new version of the connector will be v2.*
Currently, no new features are planned for the connector, and I’m not sure when there will be. So I’m okay with bumping the version to v2 just for this change. Feel free to submit a PR, and we can move forward with it.
I'm not sure if this would be a breaking change for some, so I want to discuss before sending in a PR.
I'm having to build a unique grammar for a binary column and realized that the Grammar class doesn't uniquely identify itself like the other drivers in the ecosystem for laravel. For example,
MySqlGrammar
,PostgresGrammar
, etc.If we make this change, than anyone using the
Grammar
class to override or add macros would cause breaking changes. I think this is better for the long term and want to put it on the radar.Thoughts? I'm happy to make a PR if this is the direction you want to go.
The text was updated successfully, but these errors were encountered: