Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More accessible line height #4

Closed
lukasoppermann opened this issue Feb 8, 2018 · 3 comments
Closed

More accessible line height #4

lukasoppermann opened this issue Feb 8, 2018 · 3 comments

Comments

@lukasoppermann
Copy link

Hey,
first of all, nice project.

I am just wonder why you set the line-height to 115% (https://github.com/sindresorhus/modern-normalize/blob/master/modern-normalize.css#L25)? Is it because the default leading for most browsers is between 110% to 120%?

The line height typically recommended in typography is 120–145%. Do you have a special reason? Otherwise I would recommend something like 130%, because it still looks nice, but greater leading is actually a good practise for accessibility. You could even go all the way up to 150% which is the recommended leading by the W3C accessibility guidelines.

I would think if we want to normalize, we could also try to normalize not just to the defaults, but also a little bit in the direction of an overall accessible web. Looking forward to your thoughts. 👋

@lukasoppermann lukasoppermann changed the title Fix lineheight More accessible line height. Feb 8, 2018
@sindresorhus sindresorhus changed the title More accessible line height. More accessible line height Feb 8, 2018
@sindresorhus
Copy link
Owner

See discussion about it here: necolas/normalize.css#612

@lukasoppermann
Copy link
Author

So the argument is basically to go for "normal" as in what most browser doe and not for good? So you are basically saying this would be to opinionated?

@sindresorhus
Copy link
Owner

Yeah, the point is to normalize what browsers do, even if it's not so good. Making it better is a different problem and something I intend to solve with #13. I'll definitely improve the line height there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants