-
-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More accessible line height #4
Comments
See discussion about it here: necolas/normalize.css#612 |
So the argument is basically to go for "normal" as in what most browser doe and not for good? So you are basically saying this would be to opinionated? |
Yeah, the point is to normalize what browsers do, even if it's not so good. Making it better is a different problem and something I intend to solve with #13. I'll definitely improve the line height there. |
Hey,
first of all, nice project.
I am just wonder why you set the line-height to 115% (https://github.com/sindresorhus/modern-normalize/blob/master/modern-normalize.css#L25)? Is it because the default leading for most browsers is between 110% to 120%?
The line height typically recommended in typography is 120–145%. Do you have a special reason? Otherwise I would recommend something like 130%, because it still looks nice, but greater leading is actually a good practise for accessibility. You could even go all the way up to 150% which is the recommended leading by the W3C accessibility guidelines.
I would think if we want to normalize, we could also try to normalize not just to the defaults, but also a little bit in the direction of an overall accessible web. Looking forward to your thoughts. 👋
The text was updated successfully, but these errors were encountered: