-
-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PlayCanvas #1649
Add PlayCanvas #1649
Conversation
It would be helpful to read over the pull request requirements again as you have missed several steps. |
Hi @caufieldjh - thanks for giving it a look. I did read the steps and I thought I'd fulfilled them all. Can you give me some quick pointers please? I do notice I've added some subheadings to lists. Is that one of the problems you'd like me to fix? |
Ahhh yeah, and I'm missing an image for the project. OK, on it.... |
OK, done. Sorry for the oversights there. Hopefully it's all good now. 😄 |
unicorn <- except for that of course 🤣 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
|
@sindresorhus Done. |
https://github.com/playcanvas/awesome-playcanvas#readme
A curated list of tools, tutorials, examples, and much more, for the awesome game development engine PlayCanvas.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed:
#1644
#1647
#1648
You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
Add Name of List
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.unicorn
.contributing.md
. Casing is up to you.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.