-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why don't you use git pre-push hooks? #554
Comments
👍 that wouldn't be a bad idea. However then it wouldn't look as "clean" & simplistic as => "scripts": {
"test": "xo && ava"
}, |
That's the premise actually. New contributors (even myself) sometimes forget to run Too bad Enforcing this is as simple as: echo 'exec npm test' > .git/hooks/pre-push |
Husky can help with this. (https://www.npmjs.com/package/husky) |
That's a good one. Thanks for pointing that out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For people who send you PR's without running
npm test
and realizing that after Travis CI fails.Don't you think pre-push git hook that runs
npm test
for them will prevent accidental bad pushes?The text was updated successfully, but these errors were encountered: