Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config location #5

Closed
OJFord opened this issue Aug 20, 2018 · 4 comments
Closed

Config location #5

OJFord opened this issue Aug 20, 2018 · 4 comments

Comments

@OJFord
Copy link

OJFord commented Aug 20, 2018

Could you please consider respecting $XDG_CONFIG_HOME?

That is, storing the config in the first of these where the env var exists:

  • $UM_CONFIG_HOME
  • $XDG_CONFIG_HOME/um
  • $HOME/.config/um

Alternatively, in order not to change anything for users already using $HOME/.um, simply use XDG_CONFIG_HOME if it's set (since then the user surely wants it to be used) and carry on with existing behaviour otherwise.

Many thanks for um - a simple but great idea!

@sinclairtarget
Copy link
Owner

This kinda blew up on Hacker News randomly and I haven't worked on it for a while. But you're welcome to submit a PR! It's a very simple project and should be easy to change.

Glad you like it!

@masukomi
Copy link

was just about to submit a ticket with the same request.

that being said, it should probably continue to support ~/.um as the final fallback for anyone who already has it installed and configured.

@sinclairtarget
Copy link
Owner

I've added support for a UMCONFIG_HOME env var that functions just as you suggested. See a7cedd0, which is available in the 3.1.0 release.

You're welcome to add support for XDG_CONFIG_HOME but that will require more work. Paths starting with ~ are expanded in a bunch of different places by Ruby's File::expand_path, which as far as I know does not respect XDG_CONFIG_HOME.

@OJFord
Copy link
Author

OJFord commented Apr 30, 2021

Closing as I tend to consider $[TOOL]_CONFIG_HOMEs 'good enough' in the quest/losing battle for global $XDG_CONFIG_HOME support 🙂.

@OJFord OJFord closed this as completed Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants