Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cross-encoder not improving accuracy in semantic search #26

Open
gypsydave5 opened this issue Feb 8, 2025 · 1 comment
Open

cross-encoder not improving accuracy in semantic search #26

gypsydave5 opened this issue Feb 8, 2025 · 1 comment

Comments

@gypsydave5
Copy link

Hey! I'm coding along with the course and I thought I might have made some mistake - the semantic search results re-ranked with the cross encoder have the same accuracy as the results before re-ranking.

So I pulled the notebook from this repo to run it... and it's also the same.

Has one of the models changed under the hood in the last six months? Is there anything I could try out to see a cross-encoder at work?

(enjoying the book + course otherwise - ty!)

@sinanuozdemir
Copy link
Owner

sinanuozdemir commented Feb 8, 2025

Hey David, thanks so much for letting me know! Just to be certain, you're talking about numbers from 02_semantic_search.ipynb, right? It's showing that accuracy went up after re-ranking but I'll have to re-run the code myself when I get the chance to see what may have gone wrong here!

In the meantime, here's another example of re-ranking from a RAG course I give here. I hope this helps! It's using a closed-source re-ranker though just a heads up, not open-source.

I really do appreciate you bringing this to my attention!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants