Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Is this tool still maintained? #422

Open
philolo1 opened this issue Sep 7, 2023 · 7 comments
Open

Is this tool still maintained? #422

philolo1 opened this issue Sep 7, 2023 · 7 comments

Comments

@philolo1
Copy link

philolo1 commented Sep 7, 2023

Hi, i was wondering if the tool is still maintained?

@ayax79
Copy link

ayax79 commented Oct 10, 2023

No response in over a month. 86 open issues, 28 pull requests... I guess we know the answer.

@0xmovses
Copy link

hmm I think a fork is due.

@mrcjkb
Copy link

mrcjkb commented Oct 13, 2023

@simrat39 if you don't have the resources to maintain this, would you be interested in trying to get this repo transferred to lunarmodules?

Disclaimer: I'm not part of the lunarmodules org, but it seems like the best option to me.

@TheFedaikin
Copy link

TheFedaikin commented Oct 17, 2023

There's a pretty active fork of this in terms of getting some of these PRs in.
I don't know if @MunifTanjim is comfortable maintaining it or we want to create/transfer it to an org, but that's the other option. Hopefully the ping was justified.

EDIT: I am on the path of totally transforming my setup to Fennel and will be interested in porting rust-tools into Fennel (in a couple of months probably, when I finish some other stuff), but I don't know if that hurts people ability to contribute and if there's any need for that for general public.

@mrcjkb
Copy link

mrcjkb commented Oct 17, 2023

will be interested in porting rust-tools into Fennel

Fennel is concise, which is great for configuration. But afaik it lacks type annotations (docstring/emmylua) and by extension, the ability to be statically type checked in CI.
That's why I personally wouldn't choose it for writing a plugin.

To be fair though, this plugin doesn't appear to make much use of type annotations.

@MunifTanjim
Copy link

I don't know if @MunifTanjim is comfortable maintaining it or we want to create/transfer it to an org, but that's the other option. Hopefully the ping was justified.

I don't use rust on my day job... or even use it regularly. I won't be the right person for this. 😅

@mrcjkb
Copy link

mrcjkb commented Oct 20, 2023

I've been a little frustrated1 with the fact that this plugin depends on nvim-lspconfig and that it uses a setup function, which eagerly loads everything, must be called for the plugin to work, and leads to a bunch of architectural problems2.

So now that this plugin appears to be unmaintained, I took the opportunity to start maintaining a revamped fork: rustaceanvim.
It fixes a bunch of bugs and adds some new stuff. But most importantly, it just works out of the box - without lspconfig and with minimal impact on Neovim's startup, It adds luadoc and static type checking, among other things.
The full changelog of differences is detailed here.

Footnotes

  1. Apart from that - feature-wise - this is a really great plugin!

  2. See my blog post on the topic.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants