Skip to content

Craft 5 support for Matrix #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
niektenhoopen opened this issue Aug 13, 2024 · 4 comments
Open

Craft 5 support for Matrix #10

niektenhoopen opened this issue Aug 13, 2024 · 4 comments

Comments

@niektenhoopen
Copy link
Contributor

Version 2.0.0 is currently tagged as Craft 5 compatible but does not work well with the new Matrix blocks, they are interpreted as Entry Types which is technically correct, but the plug-in seems to handle this as a Craft-4-style entry type (part of a section).

What are your plans for making this plug-in compatible with Craft v5?

@andrewmenich
Copy link
Contributor

@niektenhoopen I noticed a few issues with Matrix handling in Craft 5. I just released v2.0.1 that fixed those. It seems to be working as we intended now but if you've got a different use case or expectation in mind let us know (screenshots or examples would be helpful!) We're always open to improving things. Thanks!

@niektenhoopen
Copy link
Contributor Author

@andrewmenich It's not working as intended right now. See the screenshot below. Left is Craft v4, right is Craft v5. I am still trying to figure out what is happening.

image

@andrewmenich
Copy link
Contributor

@niektenhoopen Thanks for the feedback. There is still an issue with the count on the field layout usage on the Field page, but if you click into one of those, the resulting page should present a more accurate reflection of their actual usage. I'll get this counting issue fixed this week. Please note that currently these counts and usage reports are including drafts as well, so that might be something else we need to look into.

@niektenhoopen
Copy link
Contributor Author

@andrewmenich No, if I click into a field it shows the same behavior. It shows far too many results, I think it may be revisions or something.

I have created PR #12. This gives the correct results, but the index is still very slow. It's faster when you show the details of a specific block. The common factor was that they all had the same canonical ID so I decided to check for the uniqueness of that field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants