Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Collection addFilter should not change the collection itself #24

Open
melanke opened this issue Aug 6, 2019 · 1 comment
Open

Collection addFilter should not change the collection itself #24

melanke opened this issue Aug 6, 2019 · 1 comment

Comments

@melanke
Copy link
Member

melanke commented Aug 6, 2019

searchFiltering() {
  this.collection.addFilter({ id: 3 }).list()
}

search() {
  // I should be able to do this without the need to remove the filter
  this.collection.list()
}
@melanke melanke added bug Something isn't working highpriority labels Aug 6, 2019
@melanke melanke removed highpriority bug Something isn't working labels Aug 17, 2019
@melanke
Copy link
Member Author

melanke commented Oct 6, 2019

Actually, now I understand why it was designed like this, the real problem is the name of this object, it is not just a collection, it is a manageable list, that you can append filters and stuff. Should we change it's name?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant