Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: simplesamlphp/xml-security
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: eb4540813a5579e2bb70d1e61db48456a7ba934e
Choose a base ref
..
head repository: simplesamlphp/xml-security
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: df921e0b09bcdfe6fc80169f5566250d7a54d64d
Choose a head ref
Showing with 1 addition and 4 deletions.
  1. +0 −1 src/Assert/HMACOutputLengthTrait.php
  2. +0 −2 src/Type/HMACOutputLengthValue.php
  3. +1 −1 tests/Assert/HMACOutputLengthTest.php
1 change: 0 additions & 1 deletion src/Assert/HMACOutputLengthTrait.php
View file
Original file line number Diff line number Diff line change
@@ -49,6 +49,5 @@ protected static function validHMACOutputLength(string $value, string $message =
} catch (AssertionFailedException $e) {
throw new ProtocolViolationException($e->getMessage());
}

}
}
2 changes: 0 additions & 2 deletions src/Type/HMACOutputLengthValue.php
View file
Original file line number Diff line number Diff line change
@@ -4,10 +4,8 @@

namespace SimpleSAML\XMLSecurity\Type;

use SimpleSAML\XML\Exception\SchemaViolationException;
use SimpleSAML\XML\Type\IntegerValue;
use SimpleSAML\XMLSecurity\Assert\Assert;
use SimpleSAML\XMLSecurity\Exception\ProtocolViolationException;

/**
* @package simplesaml/xml-security
2 changes: 1 addition & 1 deletion tests/Assert/HMACOutputLengthTest.php
View file
Original file line number Diff line number Diff line change
@@ -28,7 +28,7 @@ public function testValidHMACOutputLength(bool $shouldPass, string $HMACOutputLe
try {
Assert::validHMACOutputLength($HMACOutputLength);
$this->assertTrue($shouldPass);
} catch (AssertionFailedException|ProtocolViolationException $e) {
} catch (AssertionFailedException | ProtocolViolationException $e) {
$this->assertFalse($shouldPass);
}
}