Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw a standard Error when transaction is not found #1

Open
jcramer opened this issue Oct 30, 2019 · 0 comments
Open

Throw a standard Error when transaction is not found #1

jcramer opened this issue Oct 30, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@jcramer
Copy link
Contributor

jcramer commented Oct 30, 2019

When the validator is initialized we need to check that the user-supplied method for fetching transactions (i.e., getRawTransaction) will throw when txids that do not exist are requested. This can be done by simply calling getRawTransaction during ValidatorType1 instantiation or first call to isSlpTxidValid.

  • use some impossible txid like 0000...0000
  • a short timeout should be used in case the user-suppled method hangs.
  • regardless of what the user's method throws, we should replace that by throwing the a consistent message of "Transaction data for the provided txid not found"
@jcramer jcramer added the enhancement New feature or request label May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant