Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mesh.reshape: Outdated docstring vs what is in code #311

Open
thibaut-kobold opened this issue Apr 4, 2023 · 1 comment
Open

mesh.reshape: Outdated docstring vs what is in code #311

thibaut-kobold opened this issue Apr 4, 2023 · 1 comment

Comments

@thibaut-kobold
Copy link
Contributor

x_type : {'CC', 'N', 'F', 'Fx', 'Fy', 'Fz', 'E', 'Ex', 'Ey', 'Ez'}

  • In the docstrings, accepted x_type : {'CC', 'N', 'F', 'Fx', 'Fy', 'Fz', 'E', 'Ex', 'Ey', 'Ez'}
  • in the code, allowed_x_type = [ "cell_centers", "nodes", "faces", "faces_x", "faces_y", "faces_z", "edges", "edges_x", "edges_y", "edges_z", ]

the docstring needs to be updated

@jcapriot
Copy link
Member

jcapriot commented Jun 1, 2023

we should update the doc-string here. But also those values work in the function as well. Before the input is checked against the allowed_x_type list, they are parsed and converted from the abbreviations to the full names (e.g. 'CC' -> 'cell_centers').

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants