Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugins to use new "core" CSS class #2417

Open
9 of 29 tasks
simonw opened this issue Sep 3, 2024 · 3 comments
Open
9 of 29 tasks

Update plugins to use new "core" CSS class #2417

simonw opened this issue Sep 3, 2024 · 3 comments

Comments

@simonw
Copy link
Owner

simonw commented Sep 3, 2024

Split from:

This is a tracking issue for all of the plugins that will need to add <form class="core"> in order to keep using the Datasette default button styles.

Eek that's 28! I'll manually sort them with the most important at the top.

@simonw
Copy link
Owner Author

simonw commented Sep 3, 2024

This command can help:

rg --pcre2 '<form(?:(?!core)[^>])*>' --glob 'datasette-*/**/templates/**' -l

It should find all <form ...> with no mention of core in between < and > in any folder that's a Datasette plugin templates folder.

The -l lists just filenames.

@simonw
Copy link
Owner Author

simonw commented Sep 3, 2024

Edited output of that command:

datasette-acl/datasette_acl/templates/manage_acl_group.html
datasette-acl/datasette_acl/templates/manage_acl_groups.html
datasette-acl/datasette_acl/templates/manage_table_acls.html

datasette-auth-passwords/datasette_auth_passwords/templates/password_login.html
datasette-auth-passwords/datasette_auth_passwords/templates/password_tool.html

datasette-auth-tokens/datasette_auth_tokens/templates/create_api_token.html
datasette-auth-tokens/datasette_auth_tokens/templates/token_details.html

datasette-big-local/datasette_big_local/templates/database.html

datasette-chronicle/datasette_chronicle/templates/disable-chronicle.html
datasette-chronicle/datasette_chronicle/templates/enable-chronicle.html

datasette-configure-fts/datasette_configure_fts/templates/configure_fts_database.html

datasette-create-view/datasette_create_view/templates/create_view.html

datasette-csv-url/templates/base.html

datasette-edit-schema/datasette_edit_schema/templates/edit_schema_create_table.html
datasette-edit-schema/datasette_edit_schema/templates/edit_schema_table.html

datasette-edit-templates/datasette_edit_templates/templates/edit_template.html
datasette-edit-templates/datasette_edit_templates/templates/edit_templates_index.html

datasette-embeddings/datasette_embeddings/templates/embeddings_semantic_search.html

datasette-enrichments/datasette_enrichments/templates/enrichment.html

datasette-extract/datasette_extract/templates/extract_create_table.html
datasette-extract/datasette_extract/templates/extract_to_table.html

datasette-for-datasettecloud/templates/delete_table.html
datasette-for-datasettecloud/templates/import_data.html

datasette-import-table/datasette_import_table/templates/datasette_import_table.html

datasette-import/datasette_import/templates/import_create_table.html

datasette-indieauth/datasette_indieauth/templates/indieauth.html

datasette-metadata-editable/datasette_metadata_editable/templates/datasette_metadata_editable_edit.html

datasette-notebook/datasette_notebook/templates/datasette_notebook/edit.html
datasette-notebook/datasette_notebook/templates/datasette_notebook/view.html

datasette-paste/datasette_paste/templates/paste_create_table.html

datasette-public/datasette_public/templates/public_table_change_privacy.html

datasette-query-assistant/datasette_query_assistant/templates/query_assistant.html

datasette-ripgrep/datasette_ripgrep/templates/ripgrep.html

datasette-search-all/datasette_search_all/templates/index.html
datasette-search-all/datasette_search_all/templates/search_all.html

datasette-secret-santa/datasette_secret_santa/templates/santa_reveal.html
datasette-secret-santa/datasette_secret_santa/templates/santa_set_password.html
datasette-secret-santa/datasette_secret_santa/templates/secret_santa.html

datasette-secrets/datasette_secrets/templates/secrets_update.html

datasette-socrata/datasette_socrata/templates/datasette_socrata.html

datasette-unsafe-actor-debug/datasette_unsafe_actor_debug/templates/unsafe_actor.html

datasette-upload-csvs/datasette_upload_csvs/templates/upload_csv.html

datasette-upload-dbs/datasette_upload_dbs/templates/upload_dbs.html

datasette-write/datasette_write/templates/datasette_write.html

Will use this to add checkboxes to the issue description.

simonw added a commit to simonw/datasette-edit-schema that referenced this issue Sep 3, 2024
simonw added a commit to simonw/datasette-edit-schema that referenced this issue Sep 3, 2024
simonw added a commit to simonw/datasette-auth-tokens that referenced this issue Sep 3, 2024
simonw added a commit to simonw/datasette-auth-tokens that referenced this issue Sep 3, 2024
simonw added a commit to simonw/datasette-configure-fts that referenced this issue Sep 3, 2024
simonw added a commit to simonw/datasette-configure-fts that referenced this issue Sep 3, 2024
simonw added a commit to datasette/datasette-enrichments that referenced this issue Sep 3, 2024
simonw added a commit to datasette/datasette-enrichments that referenced this issue Sep 3, 2024
simonw added a commit to simonw/datasette-auth-passwords that referenced this issue Sep 3, 2024
simonw added a commit to simonw/datasette-auth-passwords that referenced this issue Sep 3, 2024
simonw added a commit to simonw/datasette-write that referenced this issue Sep 3, 2024
Also drop menu_links in favor of database_actions

And class=core, refs simonw/datasette#2417
simonw added a commit to simonw/datasette-write that referenced this issue Sep 4, 2024
simonw added a commit to simonw/datasette-search-all that referenced this issue Sep 4, 2024
simonw added a commit to simonw/datasette-search-all that referenced this issue Sep 4, 2024
simonw added a commit to datasette/datasette-import that referenced this issue Sep 4, 2024
simonw added a commit to datasette/datasette-import that referenced this issue Sep 4, 2024
@simonw
Copy link
Owner Author

simonw commented Sep 4, 2024

New recipe for checking my progress:

rg --pcre2 '<form(?:(?!core)[^>])*>' --glob 'datasette-*/**/templates/**' -l | awk -F'/' '{print $1}' | sort | uniq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant