-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign plugin configuration to work with --plugin-secret #8
Comments
One possibility: make |
Potential short-term fix: redesign the |
OK, that's how I'm going to do this. New configuration format design: {
"plugins": {
"datasette-auth-passwords": {
"actors": {
"user1": {
"id": "user1",
"name": "Your name"
}
},
"user1_password_hash": {
"$env": "HASH_1"
}
}
}
} |
This is really just a stop-gap measure unti SQL configuration is available in #6. |
The |
While working on #7 (live demo) I realized that the suggested mechanism for keeping password hashes private - the
--plugin-secret
mechanism - doesn't actually work - because that mechanism only works for secrets at the root of the plugin configuration, not secrets that are nested further down.This is a huge problem. Even hashed passwords should not be exposed as visible in
metadata.json
.So I need a better solution to hiding them - a solution which is probably going to involve changes to Datasette core.
The text was updated successfully, but these errors were encountered: