Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to weather to remove missing values / adjust tz #25

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ismayc
Copy link

@ismayc ismayc commented Dec 26, 2024

In reference to #24. There also appears to be an issue with the timezone as noted here on moderndive/pnwflights22. Thanks!

Copy link
Owner

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this! tidyr::fill() is new to me. :)

Could you add an entry to NEWS to note these two changes? Happy to bring this changes into main and send a quick release out to CRAN at that point.

R/utils.R Outdated Show resolved Hide resolved
ismayc and others added 2 commits January 4, 2025 15:58
@ismayc
Copy link
Author

ismayc commented Jan 4, 2025

@simonpcouch NEWS.md has been updated. Feel free to change the wording as you wish, of course. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants