Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .distinct() by default for streams #3295

Open
dickermoshe opened this issue Oct 20, 2024 · 4 comments
Open

Use .distinct() by default for streams #3295

dickermoshe opened this issue Oct 20, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@dickermoshe
Copy link
Collaborator

title says it all

@dickermoshe dickermoshe added the enhancement New feature or request label Oct 20, 2024
@RoarGronmo
Copy link

I strongly agree !!

You could add an indistinct() method if you want it to do a call for every db update regardless of "real" changes or not.

@RoarGronmo
Copy link

RoarGronmo commented Nov 5, 2024

BTW: Are we sure that the distinct function will catch if there are similarities. I have situations now, in not too complex datasets that the distinct comparison "fails", so I need to provide with "manual" comparing of the datasets to be sure of the outcome. If drift could somehow provide the comparators of the datasets, it would have been very convenient.

The "failed" comparisons, seems to be produced on datasets where there are joins or partly selections in the queries.

So this could be most gracefully fixed by providing the comparators of the resulting objects in queries with joines and partly selections.

@RoarGronmo
Copy link

RoarGronmo commented Nov 5, 2024

I may post a suggestion that there should be produced comparators on more complex queries...

@RoarGronmo
Copy link

If you enables the override_hash_and_equals_in_result_sets option, it will be even better...

See #3326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants