-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename FormField Value() to getFormattedValue() #11468
Comments
This was referenced Jan 14, 2025
Trying a new thing with my review on this - lemme know if the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Split off from #11449 (comment)
FormField::getValue() was added in #11422 when implementing FieldValidation on FormFields
getValue() is confusing alongside Value() which should really be called getFormattedValue() as the method will often return a formatted version $this->value, which seems like it's intended for use within templates. It also looks like it's used a lot inside FormFields as $this->Value(), $this->getValue() should probably be used instead.
Acceptance criteria
$FormattedValue
instead of$Value
CMS 5 PRs
CMS 6 Kitchen Sink CI
CMS 6 PRs
The text was updated successfully, but these errors were encountered: