You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
SS_List is the sole archaically named class/interface from Silverstripe 3 when there were 42 classes and 4 interfaces prefixed with SS_. I think the rational behind the prefix was there we no namespaces back in those days and using an underscore was a way to make quasi namespaces.
I'm not sure why this particular interface wasn't renamed to get rid of the SS_ prefix, possibly because of a risk of a collision with a potential php reserved List class or the list() function, or maybe because it was simply missed
I think we should simply rename it to ListInterface to avoid any potential collision. Suffixing with Interface isn't ideal though it's also not completely out of line with Silverstripe naming:
Doing a quick search is sink in vendor/silverstripe/**/*.php
SS_List
is the sole archaically named class/interface from Silverstripe 3 when there were 42 classes and 4 interfaces prefixed withSS_
. I think the rational behind the prefix was there we no namespaces back in those days and using an underscore was a way to make quasi namespaces.I'm not sure why this particular interface wasn't renamed to get rid of the
SS_
prefix, possibly because of a risk of a collision with a potential php reservedList
class or thelist()
function, or maybe because it was simply missedI think we should simply rename it to
ListInterface
to avoid any potential collision. Suffixing withInterface
isn't ideal though it's also not completely out of line with Silverstripe naming:Doing a quick search is sink in vendor/silverstripe/**/*.php
^interface .*Interface = 46 matches
^interface = 171 results
While we're doing also rename any
SSList*
classes to remove theSS
prefix, e.g. SSListExporter to simply ListExporter:Related issues
Acceptance criteria
SS
prefixThe text was updated successfully, but these errors were encountered: