Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Deprecation::withNoReplacement() #11382

Closed
4 tasks done
emteknetnz opened this issue Sep 13, 2024 · 1 comment
Closed
4 tasks done

Rename Deprecation::withNoReplacement() #11382

emteknetnz opened this issue Sep 13, 2024 · 1 comment
Assignees

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Sep 13, 2024

Deprecation::withNoReplacement() is a somewhat misnamed method in that while it's used for to wrap suppressing deprecation notices for classes/methods with no replacement, it's also used to suppress those notices when calling a deprecated method or creating a deprecated class.

This is somewhat confusing and it would be better if it was simply renamed

Acceptance criteria

  • In CMS 5, rename the method to something like Deprecation::withSilentNotice()
  • Rename all existing calls to withNoReplacement() to the new method
  • Keep the old method and call the new method i.e. the old method name still works as an alias
  • Update references to withNoReplacement() in docs

PRs

@GuySartorelli GuySartorelli self-assigned this Sep 17, 2024
This was referenced Sep 17, 2024
@GuySartorelli GuySartorelli removed their assignment Sep 17, 2024
@emteknetnz
Copy link
Member Author

@GuySartorelli Note that the fluent PR was merged with withSuppressedWarning which I've asked to be changed to withSuppressedNotice, so will need a new PR to fix that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants