Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add behavioural tests #9

Closed
raissanorth opened this issue Aug 16, 2018 · 2 comments
Closed

Add behavioural tests #9

raissanorth opened this issue Aug 16, 2018 · 2 comments
Labels
affects/v4 complexity/low impact/low type/enhancement New feature or request

Comments

@raissanorth
Copy link
Contributor

Similar to the ones, added to silverstripe-elemental (see creative-commoners/silverstripe-versioned-admin@0d3208b), the banner block needs Behat tests as well.

Note, dependening on the state of silverstripe/silverstripe-behat-extension#180
and silverstripe/silverstripe-elemental#320 these tests may need to add banner blocks via the UI instead of through a fixture and rather than using breadcrumb navigation, we may need to use absolute links to the elemental editor.
@raissanorth
Copy link
Contributor Author

Made a start with #12 - there is still a lot of room for improvement though.

@robbieaverill
Copy link
Contributor

Done in #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v4 complexity/low impact/low type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robbieaverill @raissanorth