Apply fix to prevent horizontal scrollbar in the CMS admin

[lerni]

As mentioned in #1430 (comment) to make the suggested fix work with current 5.x 7b430d4 is manually reverted in this PR.

[GuySartorelli]

You mention that this undoes a commit which was part of #1422 - can you please validate whether the issue that pr fixed is regressing as a result of this change?

There's also more to this change than undoing the commit you mentioned. Are the additional changes also required?

[GuySartorelli]

(fyi I've updated the PR description and your latest comment to refer to the commit hash without a #, so that GitHub can link to it)

[GuySartorelli]

This causes a regression - https://github.com/silverstripeltd/product-issues/issues/630

Note that the issue isn't talking about the locale dropdown in the left-hand vertical menu, it's talking about the locale dropdown when creating a new locale with fluent.

Can you please see if there's a way to resolve the scrolling bug without regressing the fluent locale bug?

Also, and sorry I didn't notice this earlier, but this PR will need to target the 2.1 branch so that we can release it as a patch.

[lerni]

OK finally I know what https://github.com/silverstripeltd/product-issues/issues/630 was about (private repo) and now can reproduce.

fluen-choosen-fix.mp4

Prepared a workaround to prevent regression, but it needs some more testing.

[GuySartorelli]

@lerni How's it going with this? Have you had a chance to test your workaround yet?
Feel free to include the workaround here if you like and I can see what does/doesn't work.

[lerni]

Oh my, rebase went wrong - 'll try some more git foo. Basically now .chosen-drop (element inside container) has overflow: hidden if active.

.chosen-container:not(.chosen-container-active) .chosen-drop {...}

[GuySartorelli]

Force pushed (with no code change) to get CI to run.
I took that opportunity to update the commit message to include the FIX prefix as well.

[GuySartorelli]

Looks good to me - if CI goes green I'll merge.

[GuySartorelli]

Thanks for taking the time to get this over the line 💙