Empty import modal - Users/Groups import

[HeyImPhil]

Module version(s) affected

2.1.14

Description

When opening the import users or groups from the security admin shows an empty modal.

How to reproduce

1. Fresh install using silverstripe/installer
2. Go to the security page in the admin
3. Click Import CSV from the Users or Groups tab
4. An empty modal will appear with only the Title showing for each type i.e "Import users" or "Import groups"

Possible Solution

The ModelAdmin ImportForm method checks $importers[$this->modelTab] but the getModelImporters only returns array of import model classes so the isset check is incorrect later.

if (!$importers || !isset($importers[$this->modelTab])) {
could be changed to this
if (!$importers || !isset($importers[$this->modelClass])) {

Also the next line would need to change from
$importer = $importers[$this->modelTab];
to
$importer = $importers[$this->modelClass];

If this looks to be the right path I am happy to make a PR but don't fully understand all of the use cases that I need to account for here.

Additional Context

No response

Validations

• Check that there isn't already an issue that reports the same bug
• Double check that your reproduction steps work in a fresh installation of silverstripe/installer (with any code examples you've provided)

PRs

• FIX Set the CSV importer based on the tab, not the model #1676

[michalkleiner]

Hi @HeyImPhil. I believe this issue has been fixed in 2.1.15, please give it a go. If that's the case, feel free to close the issue.

[HeyImPhil]

Hiya @michalkleiner, still same behavior after upgrading to 2.1.15 on my fresh silverstripe/installer site

[michalkleiner]

And you ran ?flush in the admin area after the upgrade?

[GuySartorelli]

I can reproduce this locally. Probably the same thing happens for CMS 4 modeladmins that are set up in a similar way.
It seems to be a combination of #1364 reacting poorly with #1657

[emteknetnz]

Linked PR has been merged, it will auto-tag on 1.13 shortly and will auto-tag on 2.1 in the next week or so, let me know if you need this sooner