Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix altnames functionality in ftml_builder.py #89

Open
bobh0303 opened this issue Jan 22, 2024 · 0 comments
Open

fix altnames functionality in ftml_builder.py #89

bobh0303 opened this issue Jan 22, 2024 · 0 comments
Assignees

Comments

@bobh0303
Copy link
Contributor

According to the code, FTML_Builder's FChar and FSpecial classes include:

        self.altnames = {}  # alternate glyph names.
            # the above is a dict keyed by either:
            #   lang tag e.g., 'ur', or
            #   feat tag and value, e.g., 'cv24=3'
            # and returns a the glyphname for that alternate.

However in readGlyphData() it looks like only the latter key (feat tag and value) is actually added to the dictionary -- lang tags are not added.

Either change the code or change the comment.

@bobh0303 bobh0303 self-assigned this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant