Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested class names aren't handled when expanding substitution rules. #70

Open
Tracked by #1
sharoncorrell opened this issue Sep 7, 2020 · 1 comment
Open
Tracked by #1

Comments

@sharoncorrell
Copy link
Contributor

You can't use @ClassName in a substitution lookup if the class is defined in terms of other classes. So this works

lookup InsertKashida { sub @SubClass1 by @SubClass1 kashida-ar; sub @SubClass2 by @SubClass2 kashida-ar; } InsertKashida;

but not this:

lookup InsertKashida { sub @TheClass by @TheClass kashida-ar; } InsertKashida;

where @TheClass is fined in classes.xml by:

<class name="TheClass> @SubClass1 @SubClass2 </class>

This feels very uninituitive to me. The FEAX code shouldn't be affected by how the class is defined.

@sharoncorrell sharoncorrell changed the title Nested class names aren't handled expanding substitution rules. Nested class names aren't handled when expanding substitution rules. Sep 7, 2020
@sharoncorrell
Copy link
Contributor Author

It seems to make a difference whether the class is defined in classes.xml or in the FEAX file. When it is in the FEAX file, it works okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant