[WIP] Support for canary releases with EXTERNAL deployments #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anzoi/ecs-deploy into tag-only_on-first-image-only
…green deployment -- cleanup
…abel and scale; reorganised tests
…n, addded scale in deployment status
|
Given the age of this PR and that it has conflicts, I'm going to close it out. If you still want to pursue this, please submit a new PR based on the latest code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
almost done with what we started discussing in #228 (and sorry, it starts from another PR still waiting for approval, #227.
still WIP since it lacks some more documentations on README.
added support for detecting deployment controllers other than default
ECS(see$DEPLOYMENT_CONTROLLERabstraction). implementedEXTERNAL, both on force new deployment and complete service deployment.CODE_DEPLOYis not supported (and I guess it would never be, since you'd interact with code-deploy itself).few more arguments, to configure the canary deployment process:
--task-set-fileto optionally use file for task set--canary-percentto choose canary deployment size (by default, 25% of primary deployment's task set)--canary-confirmationto choose a strategy to confirm (or abort) canary deployment, with few provided ones (interactively ask to user, wait for timeout, or simply proceed) and a custom one, intended as a bash script to be executed (and proceeding on0exit code)