Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with github scopes #159

Open
lexoyo opened this issue Sep 20, 2019 · 0 comments
Open

Problems with github scopes #159

lexoyo opened this issue Sep 20, 2019 · 0 comments

Comments

@lexoyo
Copy link
Member

lexoyo commented Sep 20, 2019

Hello
Just to keep track of this, in my previous fix to be able to change github scopes (#154) there are these things I am not sure about

1- in this line, I am not sure GH API uses the X-OAuth-Scopes but if it does we probably want to change it to this.permission? for now it works for me so we should probably remove it
2- the connector expects the scope to be in the form scope=xxx, yyy, ... where intuitively I would expect just xxx, yyy, ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant