From 4ed223d06d8b3f788f703efcee26e1fa9b35369f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Airaud?= <cairaud@gmail.com>
Date: Tue, 11 Apr 2023 22:07:55 +0200
Subject: [PATCH 1/2] [forms] Remove Submit type

This was not properly supported (Not displayed
correctly). This also does not show to be really
useful, and redundant with Button component.

This fixes Issue #12.
---
 .../src/component/form/form_control.rs        | 46 +++++++++----------
 .../src/component/form/form_type.rs           |  6 +--
 2 files changed, 24 insertions(+), 28 deletions(-)

diff --git a/packages/yew-bootstrap/src/component/form/form_control.rs b/packages/yew-bootstrap/src/component/form/form_control.rs
index af3f3f7..3b04b2b 100644
--- a/packages/yew-bootstrap/src/component/form/form_control.rs
+++ b/packages/yew-bootstrap/src/component/form/form_control.rs
@@ -123,8 +123,8 @@ where T: std::fmt::Display {
 /// use yew_bootstrap::component::form::*;
 /// fn test() -> Html {
 ///   html! {
-///     <FormControl 
-///         id="input-text" 
+///     <FormControl
+///         id="input-text"
 ///         ctype={FormControlType::Text}
 ///         class="mb-3"
 ///         label="Text"
@@ -134,22 +134,22 @@ where T: std::fmt::Display {
 /// }
 /// ```
 ///
-/// Some input types need parameters for the `ctype` enum. Optional parameters use `Option` enums. 
+/// Some input types need parameters for the `ctype` enum. Optional parameters use `Option` enums.
 /// ```rust
 /// use yew::prelude::*;
 /// use yew_bootstrap::component::form::*;
 /// fn test() -> Html {
 ///   html! {
-///     <FormControl 
+///     <FormControl
 ///         id="input-number"
-///         ctype={ 
-///             FormControlType::Number { 
-///                 min: Some(10), 
+///         ctype={
+///             FormControlType::Number {
+///                 min: Some(10),
 ///                 max: Some(20)
-///             } 
+///             }
 ///         }
-///         class="mb-3" 
-///         label="Number in range 10-20" 
+///         class="mb-3"
+///         label="Number in range 10-20"
 ///         value="12"
 ///     />
 ///   }
@@ -164,17 +164,17 @@ where T: std::fmt::Display {
 /// use yew_bootstrap::component::form::*;
 /// fn test() -> Html {
 ///   html! {
-///     <FormControl 
+///     <FormControl
 ///         id="input-datetime2"
-///         ctype={ 
+///         ctype={
 ///             FormControlType::DatetimeMinMax {
 ///                 min: Some(AttrValue::from("2023-01-01T12:00")),
-///                 max: Some(AttrValue::from("2023-01-01T18:00")) 
-///             } 
+///                 max: Some(AttrValue::from("2023-01-01T18:00"))
+///             }
 ///         }
-///         class="mb-3" 
+///         class="mb-3"
 ///         label="Date and time (1st Jan 2023, 12:00 to 18:00)"
-///         value="2023-01-01T15:00" 
+///         value="2023-01-01T15:00"
 ///     />
 ///   }
 /// }
@@ -187,13 +187,13 @@ where T: std::fmt::Display {
 /// use yew_bootstrap::component::form::*;
 /// fn test() -> Html {
 ///   html! {
-///     <FormControl 
-///         id="input-select-feedback" 
-///         ctype={ FormControlType::Select} 
+///     <FormControl
+///         id="input-select-feedback"
+///         ctype={ FormControlType::Select}
 ///         class="mb-3"
 ///         label={ "Form control invalid" }
-///         validation={ 
-///             FormControlValidation::Invalid(AttrValue::from("Select an option")) 
+///         validation={
+///             FormControlValidation::Invalid(AttrValue::from("Select an option"))
 ///         }
 ///     >
 ///       <SelectOption key=0 label="Select an option" selected=true />
@@ -354,11 +354,11 @@ pub fn FormControl(props: &FormControlProps) -> Html {
                 <div class={ classes }>
                     { label_before }
                     <select
-                        class={ input_classes } 
+                        class={ input_classes }
                         id={ props.id.clone()}
                         name={ props.name.clone() }
                         disabled={ props.disabled }
-                        onchange={ props.onchange.clone() } 
+                        onchange={ props.onchange.clone() }
                         onclick={ props.onclick.clone() }
                         required={ props.required }
                     >
diff --git a/packages/yew-bootstrap/src/component/form/form_type.rs b/packages/yew-bootstrap/src/component/form/form_type.rs
index d4a06d0..28c505c 100644
--- a/packages/yew-bootstrap/src/component/form/form_type.rs
+++ b/packages/yew-bootstrap/src/component/form/form_type.rs
@@ -46,10 +46,7 @@ pub enum FormControlType {
     /// File input. Accept is a vector of formats, like "image/png", ".docx"
     File { accept: Vec<AttrValue> },
     /// Hidden input, used to transmit data
-    Hidden,
-
-    /// Submit button
-    Submit,
+    Hidden
 }
 
 impl FormControlType {
@@ -68,7 +65,6 @@ impl FormControlType {
             Self::Radio => "radio",
             Self::Range { .. } => "range",
             Self::Select => "select",
-            Self::Submit => "submit",
             Self::Text => "text",
             Self::TextArea { .. } => "",
             Self::Time | Self::TimeMinMax { .. } => "time",

From 72ce4f50720e48b8a785d7274a0bb365b058aae1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Airaud?= <cairaud@gmail.com>
Date: Tue, 11 Apr 2023 22:11:18 +0200
Subject: [PATCH 2/2] Update version

---
 packages/yew-bootstrap/Cargo.toml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/yew-bootstrap/Cargo.toml b/packages/yew-bootstrap/Cargo.toml
index 80cf05d..cc57312 100644
--- a/packages/yew-bootstrap/Cargo.toml
+++ b/packages/yew-bootstrap/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "yew-bootstrap"
-version = "0.5.13"
+version = "0.5.14"
 authors = ["Matthew Scheffel <matt@dataheck.com>", "Foorack <max@foorack.com>"]
 edition = "2021"
 license = "MIT"
@@ -22,4 +22,4 @@ log = "0.4"
 
 [dev-dependencies]
 wasm-bindgen = "0.2.*"
-web-sys = { version = "0.3.*", features = ["HtmlTextAreaElement", "HtmlSelectElement"] }
\ No newline at end of file
+web-sys = { version = "0.3.*", features = ["HtmlTextAreaElement", "HtmlSelectElement"] }