Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get lockbud running again #6413

Open
michaelsproul opened this issue Sep 19, 2024 · 1 comment
Open

Get lockbud running again #6413

michaelsproul opened this issue Sep 19, 2024 · 1 comment
Labels
code-quality infra-ci test improvement Improve tests

Comments

@michaelsproul
Copy link
Member

Description

A while ago the author of lockbud found a bunch of nice deadlocks in Lighthouse.

We are still encountering deadlocks occasionally, see:

It would be great if we could run lockbud on CI to detect them statically.

Steps to resolve

Last time we tried lockbud it had bitrotted and was incapable of compiling Lighthouse.

It seems there have been updates in the last few weeks that might make it work with more recent compiler versions!
@michaelsproul michaelsproul mentioned this issue Sep 19, 2024
Merged
@eserilev
Copy link
Collaborator

Lockbud's github action is still pinned to nightly-2023-04-11

I've opened a PR here to update the github action to the latest supported nightly version (2024-05-21)
BurtonQin/lockbud#68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-quality infra-ci test improvement Improve tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelsproul @eserilev