Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement and handle QBFT decided message #103

Open
Zacholme7 opened this issue Jan 15, 2025 · 1 comment
Open

Implement and handle QBFT decided message #103

Zacholme7 opened this issue Jan 15, 2025 · 1 comment
Labels
QBFT

Comments

@Zacholme7
Copy link
Member

Zacholme7 commented Jan 15, 2025 •
edited
Loading

Description

We are currently missing the Decided state for qbft. Extend the qbft_manager to send this messages when a quorum of commit messages has been reached.

From the spec:

We have an extra message named Decided. This message is an aggregation of a quorum of Commit messages plus the proposal data. Its main reason of existence is that, if there is a late replica that didn't receive the quorum of Commits yet, as soon as it receives the Decided message it has all the necessary information that allows it to finish the consensus execution.
@Zacholme7 Zacholme7 added the QBFT label Jan 15, 2025
@dknopik
Copy link
Member

dknopik commented Jan 15, 2025

This state is reflected by Qbft::completed returning Some. The qbft_manager can send such a message based on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
QBFT
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Zacholme7 @dknopik