Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make improvements on getAliases request #47

Closed
ipr0310 opened this issue Mar 16, 2023 · 1 comment · Fixed by #50
Closed

Make improvements on getAliases request #47

ipr0310 opened this issue Mar 16, 2023 · 1 comment · Fixed by #50

Comments

@ipr0310
Copy link
Member

ipr0310 commented Mar 16, 2023 •
edited
Loading

The function getAliases and the interface GetAliasesArgs needs to be updated.

As you can see in the picture:
image

Request URL:

https://europe3.testnet.signum.network/api?requestType=getAliases&aliasName=marine
  • accountId can be an optional
  • It should include support for aliasName property
@ipr0310
Copy link
Member Author

ipr0310 commented Mar 16, 2023

Interface URL: https://signum-network.github.io/signumjs/interfaces/core.getaliasesargs.html

@ipr0310 ipr0310 changed the title Make improvements on GetAliasesArgs Make improvements on getAliases request Mar 16, 2023
@ohager ohager mentioned this issue Mar 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adjusted GetAliases API signum-network/signumjs
1 participant
@ipr0310