Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python Example is Outdated #479

Closed
fvaliquette-splunk opened this issue Jul 22, 2024 · 4 comments
Closed

Python Example is Outdated #479

fvaliquette-splunk opened this issue Jul 22, 2024 · 4 comments
Assignees

Comments

@fvaliquette-splunk
Copy link

requirements.txt lists splunk-opentelemetry but it should be splunk-opentelemetry[all] as mentioned in Spluk official doc.

When not using [all], with default settings, we get below error.

ValueError: exporter "otlp (otlp_proto_grpc)" not found. please make sure opentelemetry-exporter-otlp-proto-grpc is installed

@pmcollins pmcollins self-assigned this Jul 23, 2024
@billg-splunk
Copy link

Is there anything holding up this change?

Would be good to know if there is a reason not to use splunk-opentelemetry[all] in certain situations.

@pmcollins
Copy link
Contributor

I'm not sure why otlp was put behind a Python extra. The next major version of Splunk Otel Python will include it by default unless we discover a reason not to.

In the meantime, I've opened this PR for adding [all] to the requirements file for the example.

@billg-splunk
Copy link

Appreciate it Pablo!

@pmcollins
Copy link
Contributor

Completed, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants