Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Move functional test to separate packages #1694

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Conversation

dmitryax
Copy link
Contributor

@dmitryax dmitryax commented Mar 5, 2025

Move functional test to separate packages instead of using build tags. The build tags are not expected to use this way and hard to work with

@dmitryax dmitryax requested review from a team as code owners March 5, 2025 23:15
@dmitryax dmitryax changed the title [chore] Move functional test to separate directories [chore] Move functional test to separate packages Mar 5, 2025
@dmitryax dmitryax marked this pull request as draft March 5, 2025 23:20
@dmitryax dmitryax marked this pull request as ready for review March 5, 2025 23:46
@dmitryax
Copy link
Contributor Author

dmitryax commented Mar 5, 2025

The k8s events has not been run apparently because of the typo in the build tag. They are failing. I'm going to skip them for now

Move functional test to separate directories instead of using build tags
@jinja2
Copy link
Collaborator

jinja2 commented Mar 6, 2025

Going to merge this and push a fix for the disabled test.

@jinja2 jinja2 merged commit 3a32a4a into main Mar 6, 2025
75 of 77 checks passed
@jinja2 jinja2 deleted the refactor-tests branch March 6, 2025 00:23
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants