Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add encrypted disk storage #803

Open
ber4444 opened this issue Apr 10, 2024 · 1 comment
Open

Add encrypted disk storage #803

ber4444 opened this issue Apr 10, 2024 · 1 comment

Comments

@ber4444
Copy link

ber4444 commented Apr 10, 2024

From https://github.com/signalfx/splunk-otel-android/blob/571c5fede657d17382b7b38f2ad69f79df2b7ed0/splunk-otel-android/src/main/java/com/splunk/rum/ZipkinWriteToDiskExporterFactory.java, it seems like you are removing the IP address from logs when using enableDiskBuffering, but no other PII is removed (location etc.), and the logs are stored unencrypted on disk. Can we add an encrypted storage option, since a lot of logs are being lost without this option (we know this for a fact by comparing to other logging solutions which we use in parallel). The lost logs are due to throttling in-memory, e.g. in case of crashes almost nothing is captured.

@breedx-splk
Copy link
Contributor

Thanks @ber4444 this is an interesting and good idea. Because we will be migrating to the OTLP based disk buffering provided by upstream OpenTelemetry, I think that we should work on offering encryption up there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants