You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For a given metric name or dimension key/value the fields are simply joined with a / instead of encoding it before, and then joining it.
Example:
A dimension with a key AwsUniqueId and value applicationelb_app/myalb/id will send a PUT request upon calling dimension_update to the URL https://api.signalfx.com/v2/dimension/AWSUniqueId/applicationelb_app/myalb/id instead of https://api.signalfx.com/v2/dimension/AWSUniqueId/applicationelb_app%2Fmyalb%2Fid.
Workaround for given example is possible by monkey patching the object instance:
This only solves the use case provided in the example, but I believe the same would apply to other methods as well. I unfortunately do not have the time to write a proper pull request for all methods that would need patching, but I believe the latter should provide enough information for a fix.
I was thinking it would be more elegant to patch the _u function, but since the endpoints have slashes inside that actually need to be non-encoded, it would not really work to apply the encoding to all arguments.
Let me know if you need any more info.
The text was updated successfully, but these errors were encountered:
Hi,
For a given metric
name
or dimensionkey/value
the fields are simply joined with a/
instead of encoding it before, and then joining it.Example:
A dimension with a key
AwsUniqueId
and valueapplicationelb_app/myalb/id
will send a PUT request upon callingdimension_update
to the URLhttps://api.signalfx.com/v2/dimension/AWSUniqueId/applicationelb_app/myalb/id
instead ofhttps://api.signalfx.com/v2/dimension/AWSUniqueId/applicationelb_app%2Fmyalb%2Fid
.Workaround for given example is possible by monkey patching the object instance:
This only solves the use case provided in the example, but I believe the same would apply to other methods as well. I unfortunately do not have the time to write a proper pull request for all methods that would need patching, but I believe the latter should provide enough information for a fix.
I was thinking it would be more elegant to patch the
_u
function, but since the endpoints have slashes inside that actually need to be non-encoded, it would not really work to apply the encoding to all arguments.Let me know if you need any more info.
The text was updated successfully, but these errors were encountered: