You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Searching for unique operations in SignalFX is difficult with PHP tracing due to the generic use of web.request for operation name.
Describe alternatives you've considered
Other than patching the function, no other solutions have been considered since $operationName seems hardcoded.
Using $_SERVER['REQUEST_URI'] for operationName could be a quick solution, but might run into cardinality constraints so i'm unsure if it's the best approach.
Additional context
Example list of differing operations all named web.request within the SignalFX Trace Explorer
The text was updated successfully, but these errors were encountered:
This case is hit when there is no routing information available, so the root span is not renamed. The same problem is actually visible using OpenTelemetry as well, when, for example, using JS the root span is named HTTP GET or HTTP PUT by the first instrumentation layer. Once there are additional instrumentations available with routing information, the root span will be updated with a low cardinality route name.
I'm thinking perhaps a mapping table of some sort would help here?
Is your feature request related to a problem? Please describe.
Searching for unique operations in SignalFX is difficult with PHP tracing due to the generic use of
web.request
for operation name.Describe the solution you'd like
Operation name for spans should not be hardcoded https://github.com/signalfx/signalfx-php-tracing/blob/main/src/DDTrace/Bootstrap.php#L107 and instead follow OpenTelemetry HTTP Semantic Conventions.
Describe alternatives you've considered
Other than patching the function, no other solutions have been considered since
$operationName
seems hardcoded.Using
$_SERVER['REQUEST_URI']
for operationName could be a quick solution, but might run into cardinality constraints so i'm unsure if it's the best approach.Additional context
Example list of differing operations all named
web.request
within the SignalFX Trace ExplorerThe text was updated successfully, but these errors were encountered: