Fix goroutine leak and close Computation.Event computation finishes #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
changed the title
pellared
changed the title
pellared
changed the title
pellared
changed the title
|
@benkeith-splunk, PTAL. I think it may be useful for https://github.com/signalfx/signalfx-k8s-metrics-adapter |
benkeith-splunk
approved these changes
Apr 24, 2024
johnbley
approved these changes
Apr 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9.
Fixes computation shutdown.
Before the fix each computation is causing a goroutine leak.
eventChBufferwas never closed.This was causing
go bufferMessages(comp.eventChBuffer, comp.eventCh)to never finish (goroutine leak) and also the channel returned byComputation.Event()was never closed.