You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
I was just reading through the code as a matter of curiosity - I've always loved signal, and wanted to see the C implementation - and noticed that you're checking if a pointer is null many times before freeing them. This is perfectly valid, but absolutely not necessary, as freealways checks for this on it's own. It thus leads to unnecessary code bloat. Nothing wrong with saving a few bytes!
Actual result: extra generated code, thus extra bloat.
Edit: see signal_protocol.c for examples.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I have:
Bug description
I was just reading through the code as a matter of curiosity - I've always loved signal, and wanted to see the C implementation - and noticed that you're checking if a pointer is null many times before
free
ing them. This is perfectly valid, but absolutely not necessary, asfree
always checks for this on it's own. It thus leads to unnecessary code bloat. Nothing wrong with saving a few bytes!Actual result: extra generated code, thus extra bloat.
Edit: see signal_protocol.c for examples.
The text was updated successfully, but these errors were encountered: