Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding stickers when editing an image is broken #6983

Open
2 tasks done
Protonator opened this issue Aug 17, 2024 · 6 comments
Open
2 tasks done

Adding stickers when editing an image is broken #6983

Protonator opened this issue Aug 17, 2024 · 6 comments

Comments

@Protonator
Copy link

Protonator commented Aug 17, 2024

Using a supported version?

  • I have searched searched open and closed issues for duplicates.
  • I am using Signal-Desktop as provided by the Signal team, not a 3rd-party package.

Overall summary

When editing an image before posting it I can no longer add custom stickers to it. I can click them, but they don't appear in the image. Only two of the "selected stickers" (a digital and an analog clock) still work as expected. I also installed a new sticker pack to check if it's just a problem with existing stickers, but the new ones doesn't work, too. This happens under Manjaro and Windows 11 with different versions of Signal Desktop (7.18.0 and above). Drawing or adding text in the image still work as expected.

Steps to reproduce

1.) Paste an image in a signal chat window.
2.) Edit the image.
3.) Try to add a custom sticker.

Expected result

The sticker gets added to the image and can be moved around.

Actual result

The sticker doesn't get added and is not visible.

Screenshots

No response

Signal version

7.18.0 (Manjaro), 7.20.0 (Windows 11)

Operating system

Manjaro KDE and Windows 11

Version of Signal on your phone

No response

Link to debug log

https://debuglogs.org/desktop/7.18.0/52792e55956be4f08ce93f01326ec8c7fe877fc197cbd02e896ce88dbc33d3e7.gz

https://debuglogs.org/desktop/7.20.0/2cad43296befc7ffce3952266343eb29912e1915a623268d92f6d198dcd91838.gz

@hackerbirds
Copy link
Contributor

I also suffer from that issue

Regression happened at 28664a6 (I tested it), that change updated the attachments by encrypting them on disk and I guess the media editor can't decrypt the stickers, so it shows nothing.

If I find a fix I'll make a PR myself, otherwise I hope that the signal devs will stop ignoring that issue lol

@hackerbirds
Copy link
Contributor

i didn't get to test it yet but it looks like they just fixed it! 697df7e

Awesome, thank you devs :)

@Protonator
Copy link
Author

Thanks for the effort! It's partially fixed now. I can add all stickers in images, but some are not getting saved and are then not visible in the posted image. For example these:

https://signalstickers.org/pack/7483b3e2302cad1a6a9c1237739427c8

Already tried to uninstall and reinstall them, but they keep getting lost.

@ayumi-signal
Copy link
Contributor

@Protonator Hm interesting, sorry about that! Could you share a debug log the next time it happens?

@Protonator
Copy link
Author

Sure thing. Here's my debug log. And thank you very much again for your great and valuable work. Much appreciated!

https://debuglogs.org/desktop/7.28.0/9830589b42b997032396a913c403c59d3d9559195821db602217b9a99f93bb3c.gz

@indutny-signal
Copy link
Contributor

Sorry for a long delay. This should be fixed in the upcoming 7.32.0-beta.1 release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants