Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Two different notification sounds are played on push notifications on Windows 11 #6905

Open
2 tasks done
Lauriichan opened this issue Jun 5, 2024 · 2 comments
Open
2 tasks done

Comments

@Lauriichan
Copy link

Lauriichan commented Jun 5, 2024

Using a supported version?

  • I have searched searched open and closed issues for duplicates.
  • I am using Signal-Desktop as provided by the Signal team, not a 3rd-party package.

Overall summary

On the windows client there are two sounds played, one is played directly by signal and the other is played by the windows notification system.
Also if notification sounds are disabled on windows, there is no sound played at all and no push notification appears which seems unexpected to me. (no longer relevant, related to "Do not disturb" mode of windows)

(Also you might want to update the bug report template, for the iOS app version there is no "General" in the Settings, you have to click on "Help" now, so it is Settings > Help > (Scroll down to "About Signal") Version)

Steps to reproduce

  1. Enable notifications
  2. Enable push notification sounds
  3. Get a message by someone while not having their chat open

Expected result

Only the windows notification sound is played and signal itself should not play any sound.

Actual result

Signal plays a sound and the windows notification system as well, making it two sounds that are played.

Screenshots

No response

Signal version

7.11.1

Operating system

Windows 11

Version of Signal on your phone

iOS: 7.11 (111)

Link to debug log

No response

@Lauriichan Lauriichan changed the title Two different notification sounds are played on push notifications on Windows 11 [BUG] Two different notification sounds are played on push notifications on Windows 11 Jun 5, 2024
@jamiebuilds-signal
Copy link
Member

@Lauriichan
Copy link
Author

Lauriichan commented Jul 12, 2024

Update: Still relevant, debug log: https://debuglogs.org/desktop/7.15.0/bb69b95fb27b69ddc39be7d586e249ca3aaec6550b774dc713c85d62cc07bcc9.gz

It seems like this is the issue:
https://github.com/signalapp/Signal-Desktop/blob/main/ts/services/notifications.ts#L232

Also if notification sounds are disabled on windows, there is no sound played at all and no push notification appears which seems unexpected to me.

This seems not to be the case anymore or was caused by windows automatically turning on "Do not disturb" mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants