Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Make it clear that 'Could not detect abi for version...' errors can be safely ignored #6889

Closed
wants to merge 0 commits into from

Conversation

ben-biddington
Copy link
Contributor

@ben-biddington ben-biddington commented May 27, 2024

First time contributor checklist:

Contributor checklist:

  • My contribution is not related to translations.
  • My commits are in nice logical chunks with good commit messages
  • My changes are rebased on the latest main branch
  • A yarn ready run passes successfully (more about tests here)
  • My changes are ready to be shipped to users

Description

This change is intended to save time for first-time contributors who encounter this error and don't understand that it is essentially a warning.

I myself have just spent a lot of time trying to resolve it.

This issue makes it more difficult when there are other problems happening as well because you're not sure whether it's related.

I am hoping to prevent issue like these needing to be raised at all:

Happy to put this documentation elsewhere and/or expand on it.

Cheers, Ben

@ben-biddington ben-biddington changed the title Make it clear that 'Could not detect abi for version...' errors can be safely ignored [DOC] Make it clear that 'Could not detect abi for version...' errors can be safely ignored May 27, 2024
@ben-biddington ben-biddington marked this pull request as ready for review May 27, 2024 21:49
@scottnonnenberg-signal
Copy link
Contributor

Thanks for looking at this. If you can tweak your wording just a little bit, to say that it appears to fail, but actually succeeds, that would be more accurate. Also, would be good to leave out the discussion out the build server.

The best approach might be to say something like "when you yarn install, you might see something like this - it can be ignored"

@ben-biddington
Copy link
Contributor Author

Okay, does that look better, @scottnonnenberg-signal ?

@ben-biddington
Copy link
Contributor Author

Oops, will have to reopen, sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants