-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Searching for links fails for domain parts which aren't the first (sub-)domain #6686
Comments
Update: It seems to go even deeper. If I send a link Update 2: highlighting seems to be unaffected. In the message
when I search for |
The same bug is affecting me. |
Yes, you can see additional details and conclusion from the Signal developer in #6460 @indutny-signal it's worth noting that according to design decision, message containing |
Related: #5964 |
In my opinion, the bug might be caused because somewhere the search string is split at the point, converting "e. g." to "e g" and "www.example.com" to "www example com". However, because of the custom FTS5 Extension mentioned in #6460 (comment) , "www.example.com." isn't actually split in the message during the search. Thus, when searching for "www.example.com" it is looking for messages containing "www% AND example% AND com%" which doesn't match the message "www.example.com" This is also consistent with this comment: #6460 (comment) and with the related issue that was just linked. |
Thank you for this information. On a second look there is indeed a mismatch between the tokenizer and the query parsing. We will look into it. |
Had a link in one of my chats to a simple CNN story: i typed 'cnn' in the search box to find it and nothing came up. Just mentioning still happening: Signal 7.17.0 (win10,64bit) |
Bug Description
When searching for parts of a link url domain that isn't the first domain part, Signal Desktop reports no matches although there clearly are. This happens in both global and per-chat search. Parts of the link which don't belong to the domain seem unaffected.
Steps to Reproduce
Actual Result:
The link is not reported in matches.
Expected Result:
The link is reported in matches.
Screenshots
-> Works
-> Doesn't work
Platform Info
Disclaimer: I am using the official manjaro/arch package (no AUR as far as I can see), but a friend has confirmed on Mint with the official repo.
Signal Version: 6.39.0
Operating System: Linux ra1n-desktop-manjaro 6.6.2-1-MANJARO #1 SMP PREEMPT_DYNAMIC Mon Nov 20 13:00:47 UTC 2023 x86_64 GNU/Linux
Linked Device Version: 6.41.2, Android
Debug log: https://debuglogs.org/desktop/6.39.0/783b3986d4d1010ad5af9bd5946ba13beeca79041d89d1a98079191ee089500e.gz
The text was updated successfully, but these errors were encountered: