Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted user from the group still receives messages #2202

Closed
1 task done
duub opened this issue Apr 1, 2018 · 20 comments
Closed
1 task done

Deleted user from the group still receives messages #2202

duub opened this issue Apr 1, 2018 · 20 comments

Comments

@duub
Copy link

duub commented Apr 1, 2018

  • I have searched open and closed issues for duplicates

Bug description

A member of a group were deleted, but still appears in the list of group members on the desktop app, not in the mobile app and is receiving my messages, not the ones from the people using the mobile app.

Steps to reproduce

  1. Have the both apps synced
  2. delete the member
  3. delete the mobile app, reinstall, resync with desktop
  4. I had to be readed in the group or at least in the mobile app i hadn't the group
  5. send a message to the group using the desktop app

Actual result:

the list of the members in the desktop app has a deleted member and him still receives my messages.

Expected result:

the list of the members in the desktop app be synced with the mobile one.

Screenshots

not know what to screenshoot... the list of the users difering from desktop and mobile?

Platform info

Signal version: Desktop: 1.6.1 Mobile: 4.18.0

Operating System: Windows 10 64-bit

Linked device version: Android 8.1.0

Link to debug log

@gasi-signal gasi-signal changed the title deleted user from the grup still receives messages Deleted user from the group still receives messages Apr 2, 2018
@gasi-signal
Copy link
Contributor

@duub Thanks for the bug report. Could you please provide debug logs from both Signal Desktop and Signal Android around the time this happens? That will help us diagnose the issue.

@MBLHarrison
Copy link

@duub When you say deleted? Are you saying you are deleting another user out of the group? Or is the user removing themselves

@Trolldemorted
Copy link
Contributor

@gasi-signal what happens if the group leave message on android fails to send?

@duub
Copy link
Author

duub commented Apr 7, 2018

@gasi-signal sorry I noticed this issue some time after that event happened, there's no log data old enough.

@MBLHarrison Someone of the group deleted the user several time ago. But in the desktop app didn't sync this event.

@martijndeb
Copy link

I have this issue as well. The process:

I was in a group, this group had people that weren't in my contact list.
I decided to leave the group. I removed myself on mobile.
Then on the desktop app, I still kept receiving messages, but only from the one person that was actually in my contacts.

This person then re added me to the group, since this was annoying so we could try to remove me again. At this point I was in the group on the desktop, receiving messages from everybody. However the group didn't show up on mobile. I'm unable to remove myself from the group now at all because the desktop doesn't provide this option.

This is my desktop debug log, it has been running all day if that helps gather data; https://debuglogs.org/da355bc82585d8af0922565fc453c5d95854354542cd2bb28953edb79f3a57a2

I'm unable to properly capture the mobile log at this point.

I hope my detailed description above helps? Maybe it's related to the to me unknown contacts?

@andy5995
Copy link

@sexybiggetje I have a friend this happened to. He was in a group I was in, which had about 5 people in it. After he left the group, he still received messages I sent to the group (but not from anyone else who was in the group).

@scottnonnenberg-signal
Copy link
Contributor

No, it likely has to do with reliable connectivity at the time of the add/remove from the group.

Because the Signal server doesn't know anything about groups, group membership is maintained by all group members. So if one client doesn't receive the message that a given member was added, it continues merrily along with an incorrect member list. Generally, the solution is to be re-added, and then ensure that all devices receive your second attempt at removing yourself from the group. But it sounds like that second add also failed! One way that can happen is if your internet connection is a little questionable.

It can also happen if people in the group have old desktop instances which haven't been online in a long time. They can miss the group update because only 1000 messages are saved for them when they come back.

@gregoriomezquita
Copy link

gregoriomezquita commented May 11, 2019

Same happen in an android group created by me. One of the member deleted himself but his desktop app in Windows 10 still receives messages from the group. Membership sync doesn't work in desktop app. This is an unacceptable leak because the rest of the members don't want to share messages with the deleted member. Also there seems to be no way to solve this situation in desktop app.

@scottnonnenberg-signal
Copy link
Contributor

@gregoriomezquita The problem isn't necessarily just his desktop, but the devices in the group which still believe that that member is in the group. You can fix this by updating the group from a mobile device which believes that he is not in the group - that will result in an update which should update the group membership on the other devices still sending to him.

@gregoriomezquita
Copy link

gregoriomezquita commented May 13, 2019 via email

@scottnonnenberg-signal
Copy link
Contributor

@gregoriomezquita "Update the group" means making a change to the group - its name, membership, or icon. That will then result in a group update message going to all members, which should fix things.

@gregoriomezquita
Copy link

@scottnonnenberg-signal I updated the group name twice but he is still receiving messages from at least one of the member but not from me which is an advance. I

@ecerum
Copy link

ecerum commented May 13, 2019

Hi there,
I am receiving messages from some of the members of a group I left almost two months ago in the desktop Signal app v1.24.1 I have got installed in two differentes computers running Windows 10.
I don't receive the messages on the mobile app v4.39.4 running Android 8.1.0.

From my point of view this is an unacceptable and critical error, for privacy, comms integrity... etc. that should be addressed as soon as possible.
The workaround/answer provided stating that some, any or all of the group members should do something sounds a bit strange, since the case must be considered and handled by the service itself with no member intervention.
Hope it is solved soon.
Regards

@stale
Copy link

stale bot commented Sep 28, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 28, 2021
@stale
Copy link

stale bot commented Oct 5, 2021

This issue has been closed due to inactivity.

@stale stale bot closed this as completed Oct 5, 2021
@naught101
Copy link

This is definitely still an issue

@greghall-au
Copy link

A workaround (but not really a proper solution) is described at : (#3342)

"... The way groups work is that when you leave a group, you need your "I left the group" message to successfully arrive on all members' devices. Otherwise those devices will still consider you part of the group.

The workaround is to have someone who doesn't have you as part of the group make a small change to the group name - like adding a space to the end. Then when that group update gets to everyone, they will all agree on the member list.Were you receiving messages from all members of the group, or just a few?"

Surely a regular 'group status update' message should be sent periodically.

It's a bit nervous-making to see a list of unknowable contacts that may or may not still be receiving messages.

@jamiebuilds-signal
Copy link
Member

@greghall-au @naught101 Both this issue and #3342 are several years old and we've replaced the implementation of groups since then. The server is able to verify missing or expired recipients, and clients can retrieve the group state (including membership) from the server. So you do not need to trigger a manual group update to ensure you have the most up to date group members.

If you have found a case where group members have been removed but are still receiving messages, please report it to [email protected] with debuglogs from your devices and please provide as much detail as possible.

@naught101
Copy link

Sorry, perhaps I've misunderstood and we're seeing a separate issue (@greghall-au and I noticed it together) the situation is:

  • We have a group that appears (to everyone we've asked) to have 150 members.
  • Some of us can see a number of users that show up as "Deleted account", or "Unknown contact", depending on the client (android, Linux, and OSX).
  • The number of those users differs depending on who looks at it. I see 28, Greg sees 12, others see none.
  • When I deleted one of those users, Greg saw that as a named user being deleted (but it wasn't someone he knew, so we couldn't check if that account was still active).

The situation is a bit disconcerting because the group is fairly large and mildly sensitive. Sorry if this is the wrong issue, I'm happy to open another one if that's useful.

@indutny-signal
Copy link
Contributor

@naught101 this is expected behavior. If the contact was registered at Signal and had a profile name at the time you joined the group, you will see their profile name. If they became unregistered before you joined the group - you'll only see "Unknown Contact".

Sorry for confusion. Hopefully this clarifies it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests