fix: type cell context #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spike-rabbit
force-pushed
the
fix/improve-cell-context
branch
from
e5984b1
to
e5fd6ec
Compare
timowolf
requested changes
Sep 26, 2024
| @@ -30,7 +30,7 @@ export interface CellContext<TRow> { | |||
| isSelected: boolean; | |||
| rowIndex: number; | |||
| treeStatus: TreeStatus, | |||
| disable$: Observable<boolean>; | |||
| disable$: BehaviorSubject<boolean>; | |||
There was a problem hiding this comment.
Why did you make this change? If there is no specific reason we could use the more generic interface.
There was a problem hiding this comment.
Our example expects this. So changing the type would break it. See: https://github.com/siemens/ngx-datatable/blob/master/src/app/basic/disabled-rows.component.ts
spike-rabbit
force-pushed
the
fix/improve-cell-context
branch
from
e5fd6ec
to
42dcd64
Compare
spike-rabbit
force-pushed
the
fix/improve-cell-context
branch
from
42dcd64
to
67b0480
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: