fix(storage): add retry mechanism to recover from a full input queue #425
+24
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chombourger
force-pushed
the
fix-write
branch
from
87ea22b
to
b79b5e5
Compare
If the client writes data too quickly, the agent may see its input queue full. Give ourselves up to 30 seconds to submit the data to be written to the shared storage before giving up. Refactor the code between local and s3 sources to make error handling consistent. Signed-off-by: Cedric Hombourger <[email protected]>
chombourger
force-pushed
the
fix-write
branch
from
b79b5e5
to
5859740
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the client writes data too quickly, the agent may see its input queue full. Give ourselves up to 30 seconds to submit the data to be written to the shared storage before giving up.