improve caching of mtda isar layer #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The layerdir variable contains an absolute path that is immediately expanded and points into the build host. This breaks sstate caching for tasks that reference this variable when building from a different path (like in the gitlab-ci). To fix this, we simply set the vardepvalue to a fixed value. As this variable just points to the current layer, there are no logical external changes expected and by that, this "pinning" is fine. Signed-off-by: Felix Moessbauer <[email protected]>
chombourger
approved these changes
Jul 21, 2023
|
Thank you @fmoessbauer for this PR. This is now merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The layerdir variable contains an absolute path that is immediately expanded and points into the build host. This breaks sstate caching for tasks that reference this variable when building from a different path (like in the gitlab-ci). To fix this, we simply set the vardepvalue to a fixed value. As this variable just points to the current layer, there are no logical external changes expected and by that, this "pinning" is fine.